Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: deae2cf1ab0a
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 48f2466671bb
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on May 8, 2020

  1. Cleanups and checks.

    pleroy committed May 8, 2020
    Copy the full SHA
    f7002b2 View commit details

Commits on May 9, 2020

  1. Copy the full SHA
    82fbd97 View commit details
  2. Merge pull request #2563 from pleroy/PossibleLeak

    Checks and cleanups added while investigating a purported leak
    pleroy authored May 9, 2020
    Copy the full SHA
    48f2466 View commit details
Showing with 4 additions and 2 deletions.
  1. +1 −0 ksp_plugin/interface.cpp
  2. +1 −1 physics/checkpointer.hpp
  3. +2 −1 physics/continuous_trajectory_body.hpp
1 change: 1 addition & 0 deletions ksp_plugin/interface.cpp
Original file line number Diff line number Diff line change
@@ -508,6 +508,7 @@ void __cdecl principia__DeserializePlugin(
*deserializer = new PushDeserializer(chunk_size,
number_of_chunks,
NewCompressor(compressor));
CHECK_NOTNULL(arena);
not_null<serialization::Plugin*> const message =
Arena::CreateMessage<serialization::Plugin>(arena);
(*deserializer)->Start(
2 changes: 1 addition & 1 deletion physics/checkpointer.hpp
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ using quantities::Time;
// needed to reconstruct the timeline after a give point in time. When
// serializing a timeline, the pairs (time, data) are written up to the oldest
// checkpoint, followed by the checkpoint itself. When deserializing, the
// the timeline may be reconstructed as needed based on the checkpoint.
// timeline may be reconstructed as needed based on the checkpoint.
// Checkpoints must be created at regular intervals because they are dropped by
// ForgetBefore: this ensures that there is always a sufficient old checkpoint
// available the next time serialization is performed.
3 changes: 2 additions & 1 deletion physics/continuous_trajectory_body.hpp
Original file line number Diff line number Diff line change
@@ -109,6 +109,7 @@ Status ContinuousTrajectory<Frame>::Append(
}

Status status;
CHECK_LE(last_points_.size(), divisions);
if (last_points_.size() == divisions) {
// These vectors are thread-local to avoid deallocation/reallocation each
// time we go through this code path.
@@ -293,7 +294,7 @@ ContinuousTrajectory<Frame>::ReadFromMessage(
continuous_trajectory->checkpointer_.ReadFromMessage(checkpoint_time,
message);

return continuous_trajectory;
return continuous_trajectory;
}

template<typename Frame>