-
-
Notifications
You must be signed in to change notification settings - Fork 104
Comparing changes
Open a pull request
base repository: NixOS/nixpkgs-channels
base: 9a29fe5808ce
head repository: NixOS/nixpkgs-channels
compare: 8ba41a1e1496
- 12 commits
- 8 files changed
- 8 contributors
Commits on May 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a4c43d9 - Browse repository at this point
Copy the full SHA a4c43d9View commit details
Commits on May 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 731cbde - Browse repository at this point
Copy the full SHA 731cbdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47df73b - Browse repository at this point
Copy the full SHA 47df73bView commit details
Commits on May 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 15a2a6d - Browse repository at this point
Copy the full SHA 15a2a6dView commit details
Commits on May 12, 2020
-
linux-rpi: use bcm2709 on arm32 rpi3
“bcmrpi3_defconfig” isn’t provided for arm32, so we need to use bcm2709_config. When on arm64, we can still use bcmrpi3_defconfig
Configuration menu - View commit details
-
Copy full SHA for c78ad0f - Browse repository at this point
Copy the full SHA c78ad0fView commit details
Commits on May 13, 2020
-
firefox: Add patch to fix AES GCM IV bit size
Regression introduced by bce5268. The bit size of the initialisation vector for AES GCM has been introduced in NSS version 3.52 in the CK_GCM_PARMS struct via the ulIvBits field. Unfortunately, Firefox 68.8.0 and 76.0 do not set this field and thus it gets initialised to zero, which in turn causes IV generation to fail. I found out about this because WebRTC stopped working after updating to NSS 3.52 and so I started bisecting. Since there wasn't an obvious error in Firefox hinting towards NSS but instead just the video stream ended up as a "null" stream, I didn't suspect the NSS update to be the culprit at first. So I verified a few times and then also started bisecting the actual commit in NSS that caused the issue. This turned out to be the problematic change: https://phabricator.services.mozilla.com/D63241 > One notable change was caused by an inconsistancy between the spec and > the released headers in PKCS#11 v2.40. CK_GCM_PARAMS had an extra > field in the header that was not in the spec. OASIS considers the > header file to be normative, so PKCS#11 v3.0 resolved the issue in > favor of the header file definition. Since the test I've used[1] was a bit flaky, I still didn't believe the result of the bisect to be accurate, but after running the test several times leading same results I dug through the above change line by line to get more clues. It fortunately didn't take that long to stumble upon the ulIvBits change (which is actually documented in the NSS 3.52 release notes[4], but I managed to blatantly ignore it for some reason) and started checking the Firefox source tree for changes regarding that field. Initialisation of that new field has been introduced[2] in preparation for the 76 release, but subsequently got reverted[3] prior to the release, because Firefox 76 is expected to be shipped with NSS 3.51, which didn't have the ulIvBits field. The patch I'm adding here is just a reintroduction of that change, because we're using NSS 3.52. Not initialising that field will break WebRTC and WebCrypto, which I think the former seems to gain in popularity these days ;-) Tested the change against the mentioned VM test[1] and also by testing manually using Jitsi Meet and Nextcloud Talk. [1]: https://github.com/aszlig/avonc/tree/884315838b6f0ebb32b/tests/talk [2]: https://hg.mozilla.org/mozilla-central/rev/3ed30e6b6de1 [3]: https://hg.mozilla.org/mozilla-central/rev/665137da70ee [4]: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.52_release_notes Signed-off-by: aszlig <aszlig@nix.build>
Configuration menu - View commit details
-
Copy full SHA for 8fb4997 - Browse repository at this point
Copy the full SHA 8fb4997View commit details -
Merge pull request #87691 from matthewbauer/linux-rpi3-arm32
linux-rpi: use bcm2709 on arm32 rpi3
Configuration menu - View commit details
-
Copy full SHA for 233e60c - Browse repository at this point
Copy the full SHA 233e60cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d977371 - Browse repository at this point
Copy the full SHA d977371View commit details -
Merge pull request #87075 from prusnak/openbazaar
openbazaar: init at 0.14.2
Configuration menu - View commit details
-
Copy full SHA for dd2fffd - Browse repository at this point
Copy the full SHA dd2fffdView commit details -
Merge pull request #87332 from r-ryantm/auto-update/python2.7-Flask-H…
…TTPAuth python27Packages.flask-httpauth: 3.3.0 -> 4.0.0
Configuration menu - View commit details
-
Copy full SHA for d5ba826 - Browse repository at this point
Copy the full SHA d5ba826View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9e3b11 - Browse repository at this point
Copy the full SHA a9e3b11View commit details -
Merge pull request #87708 from aszlig/firefox-nss-3.52-fix
firefox: Add patch to fix AES GCM IV bit size
Configuration menu - View commit details
-
Copy full SHA for 8ba41a1 - Browse repository at this point
Copy the full SHA 8ba41a1View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 9a29fe5808ce...8ba41a1e1496