Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bibtool: 2.67 -> 2.68 #87800

Closed
wants to merge 1 commit into from
Closed

bibtool: 2.67 -> 2.68 #87800

wants to merge 1 commit into from

Conversation

garrison
Copy link
Member

cf. ge-ne/bibtool#76

Motivation for this change

Bug fixes in new version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from rycee May 14, 2020 09:15
milibopp
milibopp approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@milibopp milibopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64, NixOS
  • executables tested on x86_64, NixOS
  • all depending packages build
Possible improvements

none

Comments

none

@rycee
Copy link
Member

rycee commented May 14, 2020

Thanks! Rebased to master in 1d3fbaa. Also thanks @aepsil0n for reviewing!

@rycee rycee closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milibopp milibopp milibopp approved these changes

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garrison @rycee @milibopp