Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] xonotic: split glx, sdl, dedicated, data (#83461) #87817

Closed
wants to merge 1 commit into from
Closed

[20.03] xonotic: split glx, sdl, dedicated, data (#83461) #87817

wants to merge 1 commit into from

Conversation

alexeymuranov
Copy link
Contributor

@alexeymuranov alexeymuranov commented May 14, 2020 •
edited

Motivation for this change

Cherry picked from master. Original PR: #83461. Original description below.

This has many advantages:

  • Each variant can be installed without pulling in the dependencies of the
    other variants, which makes it possible to build an SDL variant
    without X11 dependencies
  • Hydra can now build binaries without downloading 1GB of data, so users
    do not have to build them on their own machines
  • Users do not have to redownload 1GB of data after each dependency
    update

Includes the following fixes:

  • Add dependency on libGL for GLX variant as it will fail in some
    environments otherwise
  • Pass -j and -l to make to enable parallel building
  • Quote homepage URI and use https
  • Add a .desktop file and icons

(cherry picked from commit 90354cd)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alexeymuranov
xonotic: split glx, sdl, dedicated, data (#83461)
ee28acf 
This has many advantages:
- Each variant can be installed without pulling in the dependencies of the
  other variants, which makes it possible to build an SDL variant
  without X11 dependencies
- Hydra can now build binaries without downloading 1GB of data, so users
  do not have to build them on their own machines
- Users do not have to redownload 1GB of data after each dependency
  update

Includes the following fixes:
- Add dependency on libGL for GLX variant as it will fail in some
  environments otherwise
- Pass -j and -l to make to enable parallel building
- Quote homepage URI and use https
- Add a .desktop file and icons

(cherry picked from commit 90354cd)
@alexeymuranov alexeymuranov changed the title [20.03-backport] xonotic: split glx, sdl, dedicated, data (#83461) [20.03] xonotic: split glx, sdl, dedicated, data (#83461) May 14, 2020
@stale
Copy link

stale bot commented Nov 11, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 11, 2020
@alexeymuranov
Copy link
Contributor Author

Too late to backport, i think.

@alexeymuranov alexeymuranov deleted the backport-20.03-xonotic branch November 12, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@alexeymuranov