Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/buildbot: enable configurable rotation of twistd.log files #87861

Closed
wants to merge 1 commit into from
Closed

nixos/buildbot: enable configurable rotation of twistd.log files #87861

wants to merge 1 commit into from

Conversation

RomanSharapov
Copy link

Motivation for this change

In the current implementation, there's no possibility to modify the default parameters for twistd.log rotation.

By default, twistd daemon rotates log files when they reach 1M and keep all of them what leads to generating a ton of log files in the buildbotDir folder.

In order to avoid disk overflow and have a predictable log rotation, I created this patch which parametrizes log rotation settings and tailors them into buildbot.tac file which is used by twisd daemon.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nixos/buildbot: enable configurable rotation of twistd.log files
98f4c4d 
In the current implementation, there's no possibility to modify the
default parameters for twistd.log rotation.

By default twistd rotates its log files when they reach 1M and keep
all of them what leads to generating a ton of log files in the buildbotDir
folder.

In order to avoid disk overflow and have a predictable log rotation,
I created this patch  which parametrizes log rotation settings and
tailors them into buildbot.tac file which is used by twisd daemon.
@virusdave
Copy link
Contributor

@nand0p @Mic92 can you take a look at this?

@virusdave virusdave requested a review from lopsided98 May 15, 2020 15:09
@Mic92 Mic92 requested review from Lassulus and makefu May 15, 2020 15:41
@lopsided98
Copy link
Contributor

Buildbot should be configured to not produce twistd.log files, instead logging to stdout (which goes to the journal), so I'm not sure why your instance is producing these log files.

My instance's state directory only contains http.log files, whose rotation can be controlled by options in the buildbot config file.

@RomanSharapov
Copy link
Author

I guess it's my local modification of the master instance. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopsided98 lopsided98 Awaiting requested review from lopsided98

@Lassulus Lassulus Awaiting requested review from Lassulus

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RomanSharapov @virusdave @lopsided98 @Janik-Haag