Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r-statmod: Add libiconv to buildInputs #87860

Merged
merged 1 commit into from May 15, 2020
Merged

r-statmod: Add libiconv to buildInputs #87860

merged 1 commit into from May 15, 2020

Conversation

mcwitt
Copy link
Contributor

@mcwitt mcwitt commented May 15, 2020 •
edited

Motivation for this change

Fixes build failure with ld: library not found for -liconv.

Similar to #82504.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mcwitt mcwitt requested a review from peti as a code owner May 15, 2020 03:24
@peti peti merged commit c956b59 into NixOS:master May 15, 2020
@mcwitt mcwitt deleted the mcwitt/statmod-add-libiconv branch May 15, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcwitt @peti