ocamlPackages.dune_2: enable for OCaml < 4.07 #87824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
bcdarwin
suggested changes
May 15, 2020
pkgs/top-level/ocaml-packages.nix
Outdated
| @@ -219,7 +219,12 @@ let | |||
|
|
|||
| dune = callPackage ../development/tools/ocaml/dune { }; | |||
|
|
|||
| dune_2 = callPackage ../development/tools/ocaml/dune/2.nix { }; | |||
| dune_2 = | |||
| if lib.versionAtLeast ocaml.version "4.7" | |||
There was a problem hiding this comment.
Fixed. But I think it does not change anything.
vbgl
force-pushed
the
dune-2_for_the_masses
branch
from
e168dcf
to
725904a
Compare
bcdarwin
approved these changes
May 15, 2020
|
@vbgl what is delaying this? |
|
I usually wait a bit before merging my own PRs… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Have packages that use dune_2 and OCaml < 4.07.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)