Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.venvShellHook: add postVenvCreation #87850

Merged
merged 2 commits into from May 16, 2020
Merged

python3Packages.venvShellHook: add postVenvCreation #87850

merged 2 commits into from May 16, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented May 14, 2020 •
edited

Motivation for this change

defer some of the costs of doing:

pip install -r requirements.txt

to only when creating the venv environment.

I can alter the docs to include this if people feel like this should be added.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner May 14, 2020 23:46
bhipple
bhipple approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me.

@jonringer
Copy link
Contributor Author

called it postVenvCreation to make it more explicit what it's doing. Also added an entry in the docs explaining it's usage

@jonringer jonringer changed the title python3Packages.venvShellHook: add postVenv python3Packages.venvShellHook: add postVenvCreation May 15, 2020
@FRidh FRidh merged commit 15b3d9d into NixOS:master May 16, 2020
@jonringer jonringer deleted the add-postvenvhook branch May 19, 2020 00:51
rvem pushed a commit to serokell/nixpkgs that referenced this pull request Nov 8, 2022
@jonringer @rvem
python3Packages.venvShellHook: add postVenvCreation (NixOS#87850)
0942cb3 
* python3Packages.venvShellHook: add postVenvCreation

* python: docs: add postVenvCreation explaination
rvem pushed a commit to serokell/nixpkgs that referenced this pull request Nov 8, 2022
@jonringer @rvem
python3Packages.venvShellHook: add postVenvCreation (NixOS#87850)
0dec8dc 
* python3Packages.venvShellHook: add postVenvCreation

* python: docs: add postVenvCreation explaination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@d-goldin d-goldin Awaiting requested review from d-goldin

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @bhipple @FRidh