Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghostscript: 9.50 -> 9.52, jbig2dec: 0.17 -> 0.18 #87815

Merged
merged 2 commits into from Jun 4, 2020
Merged

ghostscript: 9.50 -> 9.52, jbig2dec: 0.17 -> 0.18 #87815

merged 2 commits into from Jun 4, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented May 14, 2020

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2020-12268

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @risicle

@ofborg ofborg bot requested a review from viric May 14, 2020 12:26
@puzzlewolf puzzlewolf mentioned this pull request May 22, 2020
Closed
1 task
prusnak
prusnak requested changes May 31, 2020
View reviewed changes
pkgs/development/libraries/jbig2dec/default.nix Outdated

stdenv.mkDerivation rec {
name = "jbig2dec-0.17";
name = "jbig2dec-0.18";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this into pname and version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, updated (& rebased on current staging), thanks!

@FRidh FRidh merged commit 1c7d22e into NixOS:staging Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
1.severity: security 8.has: package (update) 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmilata @prusnak @FRidh