New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alot: 0.9 → 0.9.1 #87803
alot: 0.9 → 0.9.1 #87803
Conversation
Thanks for this change. Would you like to become the maintainer of this package? I'm no longer a user of |
@@ -16,18 +16,9 @@ buildPythonPackage rec { | |||
owner = "pazz"; | |||
repo = "alot"; | |||
rev = version; | |||
sha256 = "sha256-WUwOJcq8JE7YO8sFeZwYikCRhpufO0pL6MKu54ZYsHI="; | |||
hash = "sha256:0s94m17yph1gq9f2svipb3bbwbw1s4j3zf2xkg5h91006v8286r6"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most standard way in nixpkgs
hash = "sha256:0s94m17yph1gq9f2svipb3bbwbw1s4j3zf2xkg5h91006v8286r6"; | |
sha256 = "0s94m17yph1gq9f2svipb3bbwbw1s4j3zf2xkg5h91006v8286r6"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, really? Curiously someone on IRC implied that would not be the best way to go, but no worries I'll change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hash
form is for SRI-style hashes (see the Nix 2.2 release notes), is the default output of new enough Nix, and will be preferred in the future, so it's fine to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh interesting, sorry, didn't know
Yes, I use it as my daily driver at least for private mails, so I definitely want alot to keep running smoothly on NixOS. I will update the maintainers field accordingly. |
Dropped the patch, as it is included in the point release. Switched the hash representation to regular base32.
271f379
to
0682ec4
Compare
As requested by geistesk here: NixOS#87803 (comment)
I changed the first commit to use the proper hash and added a second to take over as maintainer from @geistesk. So the PR should be ready to merge now. |
Dropped the patch, as it is included in the point release.
Switched the hash representation to regular base32.
Motivation for this change
New release came out. There are a few bug fixes in it including but not limited to the patch that was already in nixpkgs.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)