Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alot: 0.9 → 0.9.1 #87803

Merged
merged 2 commits into from May 15, 2020
Merged

alot: 0.9 → 0.9.1 #87803

merged 2 commits into from May 15, 2020

Conversation

milibopp
Copy link
Contributor

Dropped the patch, as it is included in the point release.

Switched the hash representation to regular base32.

Motivation for this change

New release came out. There are a few bug fixes in it including but not limited to the patch that was already in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxzi
Copy link
Member

oxzi commented May 14, 2020

Thanks for this change. Would you like to become the maintainer of this package? I'm no longer a user of alot and don't have the resources to maintain this package. Feel free to alter maintainers and change our names or at least drop mine.

@@ -16,18 +16,9 @@ buildPythonPackage rec {
owner = "pazz";
repo = "alot";
rev = version;
sha256 = "sha256-WUwOJcq8JE7YO8sFeZwYikCRhpufO0pL6MKu54ZYsHI=";
hash = "sha256:0s94m17yph1gq9f2svipb3bbwbw1s4j3zf2xkg5h91006v8286r6";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most standard way in nixpkgs

Suggested change
hash = "sha256:0s94m17yph1gq9f2svipb3bbwbw1s4j3zf2xkg5h91006v8286r6";
sha256 = "0s94m17yph1gq9f2svipb3bbwbw1s4j3zf2xkg5h91006v8286r6";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, really? Curiously someone on IRC implied that would not be the best way to go, but no worries I'll change it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hash form is for SRI-style hashes (see the Nix 2.2 release notes), is the default output of new enough Nix, and will be preferred in the future, so it's fine to use.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh interesting, sorry, didn't know

@milibopp
Copy link
Contributor Author

Thanks for this change. Would you like to become the maintainer of this package? I'm no longer a user of alot and don't have the resources to maintain this package. Feel free to alter maintainers and change our names or at least drop mine.

Yes, I use it as my daily driver at least for private mails, so I definitely want alot to keep running smoothly on NixOS. I will update the maintainers field accordingly.

Dropped the patch, as it is included in the point release.

Switched the hash representation to regular base32.
@milibopp
Copy link
Contributor Author

I changed the first commit to use the proper hash and added a second to take over as maintainer from @geistesk. So the PR should be ready to merge now.

@teto teto merged commit 7319061 into NixOS:master May 15, 2020
@milibopp milibopp deleted the upgrade-alot-0.9.1 branch May 15, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants