Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starship: 0.41.0 -> 0.41.1 #87840

Merged
merged 2 commits into from May 14, 2020
Merged

starship: 0.41.0 -> 0.41.1 #87840

merged 2 commits into from May 14, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented May 14, 2020

Motivation for this change

https://github.com/starship/starship/releases/tag/v0.41.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@bbigras
Copy link
Contributor

bbigras commented May 14, 2020

Result of nixpkgs-review pr 87840 1

1 package built:
- starship

@bbigras
Copy link
Contributor

bbigras commented May 14, 2020

Builds and runs fine. Thanks 👍

@garbas garbas merged commit efdeb1a into NixOS:master May 14, 2020
@Frostman Frostman deleted the starship-0.41.1 branch May 14, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants