Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.batteries: fix for OCaml 4.10 #87791

Merged
merged 1 commit into from May 20, 2020
Merged

ocamlPackages.batteries: fix for OCaml 4.10 #87791

merged 1 commit into from May 20, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented May 14, 2020

Motivation for this change

Tests fail with OCaml 4.10

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented May 14, 2020

@GrahamcOfBorg build satysfi fstar ocaml-ng.ocamlPackages_4_10.batteries

@Mic92
Copy link
Member

Mic92 commented May 14, 2020

Result of nixpkgs-review pr 87791 1

2 packages built:
- fstar
- satysfi

@vbgl vbgl merged commit 0900872 into NixOS:master May 20, 2020
@vbgl vbgl deleted the ocaml-batteries-fix-4.10 branch May 20, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @Mic92