Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] nomachine-client: 6.9.2 -> 6.10.12, add archive.org to source urls #87844

Merged
merged 2 commits into from May 15, 2020
Merged

[20.03] nomachine-client: 6.9.2 -> 6.10.12, add archive.org to source urls #87844

merged 2 commits into from May 15, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented May 14, 2020

Motivation for this change

Backport #87797 and #87843 to 20.03, updating nomachine-client to the latest release and adding archive.org as a download fallback.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

megheaiulian and others added 2 commits May 14, 2020 23:18
@megheaiulian @talyz
nomachine-client: 6.9.2 -> 6.10.12
c497f5c 
(cherry picked from commit 46213cf)
@talyz
nomachine-client: Add archive.org to source urls
2fbd484 
NoMachine removes each old release as soon as a new one is available,
resulting in failed downloads. Thankfully, the Internet Archive
provides backups of old downloads, so we can use it as a fallback.

(cherry picked from commit 022f2cc)
@talyz talyz requested a review from megheaiulian May 14, 2020 21:29
@talyz talyz merged commit 2ad09a0 into NixOS:release-20.03 May 15, 2020
@talyz talyz deleted the nomachine-6.10.12-archive-20.03 branch May 15, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megheaiulian megheaiulian megheaiulian approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@talyz @megheaiulian