Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgcrypt: always pass build and host to configure #87845

Merged
merged 1 commit into from Jun 19, 2020
Merged

libgcrypt: always pass build and host to configure #87845

merged 1 commit into from Jun 19, 2020

Conversation

Gaelan
Copy link
Contributor

@Gaelan Gaelan commented May 14, 2020

Motivation for this change

When building for aarch32 on aarch64 with extraPlatforms, libgcrypt fails to build because it tries to guess the host platform from uname, which returns the wrong result in this case. We fix this by always telling libgcrypt what platform to build for.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gaelan
libgcrypt: always pass build and host to configure
a462135 
When building for aarch32 on aarch64 with extraPlatforms, libgcrypt
fails to build because it tries to guess the host platform from uname,
which returns the wrong result in this case. We fix this by always
telling libgcrpyt what platform to build for.
@ofborg ofborg bot requested a review from vrthra May 14, 2020 21:37
@FRidh FRidh added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Jun 19, 2020
@FRidh FRidh added this to WIP in Staging via automation Jun 19, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging Jun 19, 2020
@FRidh FRidh merged commit d179098 into NixOS:staging Jun 19, 2020
Staging automation moved this from Needs review to Done Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gaelan @FRidh