treewide: remove uses of p7zip #87837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package has been broken since 2017, essentially untouched since 2014, and has no maintainers. The last upstream release was in 2016; the download link for that release is dead. Although i was able to download it via BitTorrent, that sounds hard to integrate into NixOS. Additionally, the latest phone the program works with was released in 2013, so I suspect the demand is fairly minimal. Given the amount of TODOs in the derivation and its long-broken state, I conclude that any update of this package would likely be as much effort as packaging it from scratch, and since nobody as stepped up to do so in several years, it can be safely removed.
libarchive can't handle this `.7z` file:
zdoom> unpacking sources
zdoom> tools/re2c/CHANGELOG: Lzma library error: Invalid options
zdoom> bsdtar: Error exit delayed from previous errors.
Hydra won't build this so it probably shouldn't be used to extract derivation sources. libarchive is a suitable alternative.
10 tasks
6 tasks
|
Note: there is #90140 |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Hi, Do you think we can close this draft PR ? |
stale
bot
removed
the
2.status: stale
|
Yeah sure. Probably some of these could be updated and merged but given that |
|
Fair enough, I let you close it then :) |
|
Probably not going to get back to this any time soon so I'll close, thanks for the ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Work in progress; part of the long follow-up to #86417. This is just focused on fixing derivations that use p7zip at build time rather than applications that use p7zip themselves.
cc @tstrobel; I couldn't manage to get the various
win-*derivations that extract MSIs working, as I don't fully understand p7zip's behaviour here; it seems to collapse/ignore parts of the extracted hierarchy and do less extraction compared tomsiextract. For example, is it really intended that${pkgs.win-signed-gplpv-drivers}/amd64mostly contains a bunch of installer metadata and a monolithicgplpv.cabfile?Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)