Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/rl-2009: Remove unnecessary </programlisting> #87806

Closed
wants to merge 1 commit into from
Closed

doc/rl-2009: Remove unnecessary </programlisting> #87806

wants to merge 1 commit into from

Conversation

devhell
Copy link
Contributor

@devhell devhell commented May 14, 2020 •
edited

Introduced in c5f18c4, this removes the unnecessary tag and unbreaks document building.

Motivation for this change

Unbreak documentation build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@devhell
doc/rl-2009: Remove unnecessary </programlisting>
f36ebec 
Introduced in c5f18c4, this removes the
unnecessary tag and unbreaks document building.
@emilazy
Copy link
Member

emilazy commented May 14, 2020

Fixed by @flokli in 6f4f37d.

@emilazy emilazy closed this May 14, 2020
@flokli
Copy link
Contributor

flokli commented May 14, 2020 via email

@devhell devhell deleted the fix-rl-2009 branch May 14, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devhell @emilazy @flokli