Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomachine-client: 6.9.2 -> 6.10.12 #87797

Merged
merged 1 commit into from May 14, 2020
Merged

nomachine-client: 6.9.2 -> 6.10.12 #87797

merged 1 commit into from May 14, 2020

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented May 14, 2020 •
edited

Motivation for this change

Upgrades nomachine-client 6.10.12
Notes: 6.9.2 seems to no longer even be available for download so its kind of important to merge this (maybe even backport later)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from talyz May 14, 2020 08:26
@austinbutler austinbutler mentioned this pull request May 14, 2020
Closed
@talyz talyz linked an issue May 14, 2020 that may be closed by this pull request
nomachine-client hash mismatch #80577
Closed
@talyz
Copy link
Contributor

talyz commented May 14, 2020

Works well in my tests. Thank you! :)

@talyz talyz merged commit 4f7a8b4 into NixOS:master May 14, 2020
@talyz talyz mentioned this pull request May 14, 2020
Merged
10 tasks
@megheaiulian megheaiulian deleted the feature/nomachine-client-6.10.12 branch May 15, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz Awaiting requested review from talyz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nomachine-client hash mismatch
2 participants
@megheaiulian @talyz