Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscodium: Fix .desktop file #87799

Merged
merged 1 commit into from May 14, 2020
Merged

vscodium: Fix .desktop file #87799

merged 1 commit into from May 14, 2020

Conversation

turion
Copy link
Contributor

@turion turion commented May 14, 2020 •
edited

Motivation for this change

Fix #87768.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@piegamesde as reporter, can you test this PR by using nix-shell -p nixpkgs-review --run "nixpkgs-review 87799"?
@Synthetica9 Can you review and/or merge?

@ofborg ofborg bot requested a review from Synthetica9 May 14, 2020 08:30
@piegamesde
Copy link
Member

nix-shell -p nixpkgs-review --run "nixpkgs-review 87799" errors out with

usage: /nix/store/13ww51z1jlw5rsb0bvidd1nz9hiv4jfg-nixpkgs-review-2.3.1/bin/nixpkgs-review
       [-h] {post-result,approve,merge,pr,rev,wip} ...
/nix/store/13ww51z1jlw5rsb0bvidd1nz9hiv4jfg-nixpkgs-review-2.3.1/bin/nixpkgs-review: error: argument subcommand: invalid choice: '87799' (choose from 'post-result', 'approve', 'merge', 'pr', 'rev', 'wip')

But nix-shell -p nixpkgs-review --run "nixpkgs-review 87799" runs just fine, if that's the correct thing I should do (disclaimer: this is my first nixpkgs bug report).

I also tried simply running vscodium from the PR branch and it resolves the issue for me.

@turion
Copy link
Contributor Author

turion commented May 14, 2020

nix-shell -p nixpkgs-review --run "nixpkgs-review 87799" errors out with

usage: /nix/store/13ww51z1jlw5rsb0bvidd1nz9hiv4jfg-nixpkgs-review-2.3.1/bin/nixpkgs-review
       [-h] {post-result,approve,merge,pr,rev,wip} ...
/nix/store/13ww51z1jlw5rsb0bvidd1nz9hiv4jfg-nixpkgs-review-2.3.1/bin/nixpkgs-review: error: argument subcommand: invalid choice: '87799' (choose from 'post-result', 'approve', 'merge', 'pr', 'rev', 'wip')

Ooops, my bad. Should have been nix-shell -p nixpkgs-review --run "nixpkgs-review pr 87799" (Note the missing pr)

I also tried simply running vscodium from the PR branch and it resolves the issue for me.

Well, that's the best then :)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/156

@bhipple
Copy link
Contributor

bhipple commented May 14, 2020

Result of nixpkgs-review pr 87799 1

1 package built:
- vscodium

@bhipple bhipple merged commit 91fce0f into NixOS:master May 14, 2020
@turion turion deleted the fix_vscodium_desktop_file_87768 branch May 15, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSCodium desktop file specifies wrong StartupWMClass
4 participants
@turion @piegamesde @nixos-discourse @bhipple