Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman, etc packages: switch to buildGoModule #87794

Merged
merged 5 commits into from May 14, 2020
Merged

podman, etc packages: switch to buildGoModule #87794

merged 5 commits into from May 14, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 14, 2020

#86376 allows us to use buildGoModule with a vendor folder.

runc currently doesn't work with buildGoModule. It will in the next release, I think we can wait for then to switch over as I don't think hacking around it is worth it, especially as runc is widely used.

cri-o already has an open PR for this change #86378

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that's nice!

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@nlewo nlewo merged commit a33eb1a into NixOS:master May 14, 2020
@zowoq zowoq deleted the gomodules branch May 14, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants