Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jrnl: 1.9.8 -> 2.4.2 #87793

Closed
wants to merge 4 commits into from
Closed

jrnl: 1.9.8 -> 2.4.2 #87793

wants to merge 4 commits into from

Conversation

Br1ght0ne
Copy link
Member

Motivation for this change

https://github.com/jrnl-org/jrnl/releases/tag/v2.4.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed May 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

https://github.com/NixOS/nixpkgs/pull/87793
1 package failed to build:
python27Packages.asteval

3 packages built:
jrnl python37Packages.asteval python38Packages.asteval

pkgs/development/python-modules/asteval/default.nix Show resolved Hide resolved
pkgs/development/python-modules/asteval/default.nix Show resolved Hide resolved
@Gaelan
Copy link
Contributor

Gaelan commented May 15, 2020

Build fails on Darwin. Adding cryptography to propagatedBuildInputs fixes it.

Br1ght0ne and others added 2 commits May 15, 2020 10:42
@Br1ght0ne @jonringer
jrnl: disable on Python 2.7
75c35b9 
Co-authored-by: Jon <jonringer@users.noreply.github.com>
@Br1ght0ne @Gaelan
jrnl: add cryptography to propagatedBuildInputs
aebefab 
Fixes build on Darwin.

Co-authored-by: Gaelan <gbs@canishe.com>
@Br1ght0ne

This comment has been minimized.

Sign in to view
@fabaff
Copy link
Member

fabaff commented Feb 12, 2021

Was superseded by #112684.

@fabaff fabaff closed this Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Br1ght0ne @Gaelan @fabaff @jonringer @ryantm