Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mysql: refactor enable option #87812

Merged
merged 1 commit into from May 28, 2020
Merged

nixos/mysql: refactor enable option #87812

merged 1 commit into from May 28, 2020

Conversation

joachimschmidt557
Copy link
Member

Motivation for this change

More consistency with other NixOS modules (see #87177)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joachimschmidt557 joachimschmidt557 mentioned this pull request May 27, 2020
Merged
10 tasks
rnhmjoj
rnhmjoj approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just a note: if you many simple changes, such as this one, it's ok to make a single PR.

@rnhmjoj rnhmjoj merged commit 429f976 into NixOS:master May 28, 2020
@joachimschmidt557 joachimschmidt557 deleted the mysql-enable-option branch May 28, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joachimschmidt557 @rnhmjoj