New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tamzen: init at 1.11.4 #87842
tamzen: init at 1.11.4 #87842
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most fonts also use fetchzip, as you don't really need a stdenv. Althought the otb creation may warrant otherwise
cc @rnhmjoj
also, thanks for opening your first PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package looks good. I still have to test the .otb fonts: fontforge doesn't always produce good results.
Tested the otb fonts in urxvt and they seem all right. |
I've done the requested changes. Thanks for reviewing, I'm not well versed with Nix, so I at first packaged tamzen for it to just work.
Thanks! I'm trying NixOS and found that it didn't package the coolest font I know of, so I felt that I had to contribute. |
Can you squash the subsequent changes to If you have never done it before you can do it like this:
You should keep two commits:
|
Done. |
Thank you! |
Motivation for this change
Tamsyn is a cool font, but it doesn't have a powerline version.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
) (none)nix path-info -S
before and after)