Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precice: 2020-01-20 -> 2.0.2 #87816

Merged
merged 1 commit into from Jun 2, 2020
Merged

precice: 2020-01-20 -> 2.0.2 #87816

merged 1 commit into from Jun 2, 2020

Conversation

Scriptkiddi
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Scriptkiddi Scriptkiddi force-pushed the precice2 branch 3 times, most recently from 07afa75 to 56fce9c Compare May 14, 2020 12:52
@srhb srhb marked this pull request as draft May 14, 2020 18:53
@Scriptkiddi Scriptkiddi marked this pull request as ready for review May 23, 2020 11:29
@Lassulus
Copy link
Member

is the binary meant to be named binprecice ?

@Scriptkiddi
Copy link
Contributor Author

yes

@Lassulus Lassulus merged commit 09da70f into NixOS:master Jun 2, 2020
@Scriptkiddi Scriptkiddi deleted the precice2 branch June 2, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Scriptkiddi @Lassulus