Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccls: Use latest llvmPackages #87848

Closed
wants to merge 1 commit into from
Closed

ccls: Use latest llvmPackages #87848

wants to merge 1 commit into from

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented May 14, 2020 •
edited

Motivation for this change

In order to decrease overall closure size and to align with Nixpkgs' policy regarding the issue, packages which can work with the latest version of libfoo should use the latest version of it, even if libfoo points to libfoo2 while there's also libfoo3 available. This is influential on closure size in the following scenario:

  • A user installs Program A which depends on libfoo.
  • libfoo points to libfoo2.
  • There's also a libfoo_latest which points to libfoo3.
  • The user installs Program B which depends on libfoo_latest which is libfoo3.
  • Program A can work with both libfoo3 and libfoo2.

The result of this somewhat common pattern is that the user has both libfoo2 and libfoo_latest in their store, but it's not necessary because Program A can use libfoo_latest instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
ccls: Use latest llvmPackages if possible
9b58388 
On Darwin, according to ofborg the build fails but Linux should still
use the latest version if possible, see:
https://discourse.nixos.org/t/nixpkgs-policy-regarding-libraries-available-in-multiple-versions/7026
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixpkgs-policy-regarding-libraries-available-in-multiple-versions/7026/4

@doronbehar
Copy link
Contributor Author

Not interested in this anymore.

@doronbehar doronbehar closed this Nov 5, 2020
@doronbehar doronbehar deleted the improve-ccls branch March 2, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @nixos-discourse