Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] slirp4netns 0.4.3 -> 0.4.5 #87808

Merged
merged 2 commits into from May 15, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented May 14, 2020

Contains backport of #82902 + bump to 0.4.5.

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2020-1983 (the CVE is for libslirp which is vendored in this version of slirp4netns)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drewrisinger
Copy link
Contributor

@mmilata did you also bump master to 0.4.5? feels weird to have release-20.03 ahead of master.

@zowoq
Copy link
Contributor

zowoq commented May 14, 2020

Master was updated from 0.4.4 to 1.0.0. 237a1e7

@adisbladis adisbladis merged commit ba86df0 into NixOS:release-20.03 May 15, 2020
@mmilata mmilata deleted the 20.03/slirp4netns-0.4.5 branch May 15, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants