dell/xps/13-9360: Stop using i18n.consoleFont #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnhmjoj
reviewed
May 14, 2020
trace: warning: The option `i18n.consoleFont' defined in `/nix/var/nix/profiles/per-user/root/channels/nixos-hardware/dell/xps/13-9360' has been renamed to `console.font'.
|
Michele Guerini Rocco writes:
It may be useful to keep compatibility with the old name for a while
Thanks for the tip, I have amended my commit.
|
|
Lgtm |
rnhmjoj
approved these changes
May 14, 2020
|
I cannot reproduce the CI failure but it is unrelated to this PR. |
|
Jörg Thalheim writes:
I cannot reproduce the CI failure but it is unrelated to this PR.
All the tests passed when I ran them locally, and they passed the first
time I pushed a commit. Very weird.
Anyway, thank you for the reviews and for the merge!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deprecation warning: