Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonFull: add BlueZ support #91281

Merged
merged 1 commit into from Aug 15, 2020
Merged

pythonFull: add BlueZ support #91281

merged 1 commit into from Aug 15, 2020

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Jun 22, 2020

Motivation for this change

This PR introduces two changes.

First, cpython gets optional BlueZ support, which is needed for
AF_BLUETOOTH sockets. Therefore bluezSupport was added as a parameter.

Second, the call to the pythonFull packages has been adjusted. The
Python packages have a self-reference called self. This was not reset
during the previous overwrite. As a result, Python packages for this
version of Python were not built with the overwritten Python, but with
the original one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxzi oxzi requested a review from FRidh as a code owner June 22, 2020 10:55
@jtojnar
Copy link
Contributor

jtojnar commented Jun 22, 2020

Closes: #6414

cc @samueldr (https://logs.nix.samueldr.com/nixos-chat/2020-05-18#1589768667-1589768728;)

@mweinelt
Copy link
Member

mweinelt commented Jun 22, 2020 •
edited

Result of nixpkgs-review pr 91281 1

5 packages built:
- python35Full
- python36Full
- python37Full
- python3Full (python38Full)
- python39Full 
[nix-shell:~/.cache/nixpkgs-review/pr-91281]$ ./results/python3Full/bin/python
Python 3.8.3 (default, May 13 2020, 19:59:26) 
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import socket
>>> socket.AF_BLUETOOTH
<AddressFamily.AF_BLUETOOTH: 31>

@oxzi oxzi force-pushed the python-full-self-ref-bluez branch from 53e8cea to 551983c Compare June 22, 2020 15:35
@ofborg ofborg bot requested a review from FRidh June 22, 2020 15:44
@oxzi
Copy link
Member Author

oxzi commented Jul 19, 2020

This seems kind of stalled.

@FRidh: Would you be so kind and take another look at this PR? Thanks.

@mweinelt
Copy link
Member

@FRidh @jonringer Can we get this in before 20.09?

@oxzi
pythonFull: add BlueZ support
4c95c1d 
This commit introduces two changes.

First, cpython gets optional BlueZ support, which is needed for
AF_BLUETOOTH sockets. Therefore bluezSupport was added as a parameter.

Second, the call to the pythonFull packages has been adjusted. The
Python packages have a self-reference called self. This was not adjusted
for the override. As a result, Python packages for this special version
of Python were not built with the overridden Python, but with the
original one.
@oxzi oxzi force-pushed the python-full-self-ref-bluez branch from 551983c to 4c95c1d Compare August 15, 2020 16:02
@FRidh FRidh merged commit b7ce309 into NixOS:master Aug 15, 2020
@oxzi oxzi deleted the python-full-self-ref-bluez branch August 15, 2020 16:11
@oxzi oxzi mentioned this pull request Aug 15, 2020
Closed
@jonringer
Copy link
Contributor

sorry, I was on vacation when this got opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oxzi @jtojnar @mweinelt @jonringer @FRidh