Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 377345e26f1a
Choose a base ref
...
head repository: NixOS/nix
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 334e26bfc2ce
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jun 22, 2020

  1. nix flake check: Don't build apps

    This was inconsistent since we're not building 'packages' or
    'defaultPackage' either.
    
    Closes #3726.
    edolstra committed Jun 22, 2020
    Copy the full SHA
    334e26b View commit details
Showing with 1 addition and 3 deletions.
  1. +1 −3 src/nix/flake.cc
4 changes: 1 addition & 3 deletions src/nix/flake.cc
Original file line number Diff line number Diff line change
@@ -246,9 +246,7 @@ struct CmdFlakeCheck : FlakeCommand
auto app = App(*state, v);
for (auto & i : app.context) {
auto [drvPathS, outputName] = decodeContext(i);
auto drvPath = store->parseStorePath(drvPathS);
if (!outputName.empty() && drvPath.isDerivation())
drvPaths.push_back({drvPath});
store->parseStorePath(drvPathS);
}
} catch (Error & e) {
e.addPrefix(fmt("while checking the app definition '" ANSI_BOLD "%s" ANSI_NORMAL "' at %s:\n", attrPath, pos));