Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.qscintilla-qt5: Do not copy pyqt5 tree #91278

Merged
merged 1 commit into from Jul 6, 2020

Conversation

lsix
Copy link
Member

@lsix lsix commented Jun 22, 2020

Motivation for this change

This commit ensures the entire PyQt5 tree is not included inside
qscintilla as pointed out by
#73975 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This commit ensures the entire PyQt5 tree is not included inside
qscintilla as pointed out by
NixOS#73975 (comment)
@bhipple
Copy link
Contributor

bhipple commented Jul 6, 2020

Result of nixpkgs-review pr 91278 1

6 packages built:
- python27Packages.qscintilla-qt5
- python37Packages.qscintilla-qt5
- python38Packages.qscintilla-qt5
- qgis
- qgis-unwrapped
- tortoisehg

@bhipple bhipple merged commit 38b5270 into NixOS:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants