Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/onlykey: fix typo #91296

Merged
merged 1 commit into from Aug 21, 2020
Merged

nixos/onlykey: fix typo #91296

merged 1 commit into from Aug 21, 2020

Conversation

cawilliamson
Copy link
Member

Motivation for this change

Correct an issue which prevents this option being used.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cawilliamson cawilliamson mentioned this pull request Jun 22, 2020
Closed
prusnak
prusnak requested changes Jun 22, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to nixos/onlykey: fix typo

@cawilliamson cawilliamson changed the title Correct typo in onlydev.nix nixos/onlykey: fix typo Jul 7, 2020
@cawilliamson
Copy link
Member Author

@prusnak I've addressed your feedback - apologies for the delay - been busy with work!

@Lassulus Lassulus merged commit 6f87509 into NixOS:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cawilliamson @prusnak @Lassulus