Hey @GuillaumeDesforges,

cool that you are working on this.

I am a bit apprehensive about deploying a software for which the developers intentionally decided not to do a release yet. Especially since we might expected additional maintenance overhead. But that‘s not on me to decide. I‘d actually love to test hls, so why not.^^

I will just give you a bit of feedback inline. I hope that‘s okay even if this is still WIP. Feel free to ignore.

btw. can you please make haskell PRs against the haskell-updates branch? It will get merged into master once a week, if we are sure that everything works fine.

Thanks for the review @maralorn , it is always appreciated !

As it is a WIP PR I might not apply everything right now (since it's still changing/moving around a lot) but once it stabilizes I will properly do all the above. Let's keep things clean!

@maralorn Sorry to bother you, but it seems like ./Setup build from buildPhase makes a dist folder... while ./Setup test expects a dist-newstyle folder. Does it ring a bell to you ?

https://gist.github.com/GuillaumeDesforges/7da3253decd1e5b3ac8776cd0f184747

running tests
Running 1 test suites...
Test suite tests: RUNNING...
tests: dist-newstyle: getDirectoryContents:openDirStream: does not exist (No such file or directory)
Test suite tests: FAIL

Can‘t say that I have encountered this one before.

I mean the general issue is the difference between cabal v1-build (which uses dist) and cabal v2-build (which uses dist-newstyle). So maybe you can fix this by using ./Setup v2-build or something?

I'm not sure if it is a Nixpkgs issue (for instance related to a cabal version/haskell wrapping voodoo) or an issue from lsp-test itself.
As of now, I'll put dontCheck on this package. Note that it is the lsp-test_0_11_0_2, not lsp-test, so it has a narrow scope of impact.

It seems to work, let's squash and go

Rebased

Thanks @cdepillabout for the feedback, will do it right away 👍

Lost a lot of time when trying to automate the update process since cabal2nix was not fetching the same revision of the ghcide fork as the one used by hls, but now this looks pretty good!

@GuillaumeDesforges Thank you for putting so much work into this!

I have compiled and tested this on a project of mine with neovim+coc.nvim. Works like a charm.

We should probably do something like #89450 for haskell-language-server, too.

I have also tried running the ./update.sh script. It reproduced exactly the same to nix expressions. Seems to work.

We should probably do something like #89450 for haskell-language-server, too.

I'm open to suggestions, but I think this can be done in another PR so that this "step" is closed and I can move on in my life ;)

We should probably do something like #89450 for haskell-language-server, too.

I'm open to suggestions, but I think this can be done in another PR so that this "step" is closed and I can move on in my life ;)

By all means. Let‘s do that in a later PR.

@GrahamcOfBorg build haskellPackages.haskell-language-server

@GuillaumeDesforges This looks good! Thanks for going back and forth with us so much on this.

@maralorn Thanks for your reviews as well.

Thank you very much for your time and comments, I learned a lot doing this PR :)

this package doesn't build for ghc 8.10.1 btw:

nix-repl> :b nixpkgs.haskell.packages.ghc8101.haskell-language-server
builder for '/nix/store/csy7bipjf6hcqkvzyfa3mksz6gaphq09-data-tree-print-0.1.0.2.drv' failed with exit code 1; last 10 log lines:
    $, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:1024:20 in Cabal-3.2.0.0:Distribution.Simple.Configure
    configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:477:12 in Cabal-3.2.0.0:Distribution.Simple.Configure
    configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:625:20 in Cabal-3.2.0.0:Distribution.Simple
    confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:65:5 in Cabal-3.2.0.0:Distribution.Simple.UserHooks
    configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:180:19 in Cabal-3.2.0.0:Distribution.Simple
    defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:116:27 in Cabal-3.2.0.0:Distribution.Simple
    defaultMain, called at Setup.hs:2:8 in main:Main
  Setup: Encountered missing or private dependencies:
  base >=4.8 && <4.14
cannot build derivation '/nix/store/4dc9dn4h0pqqwm854sz56nkfksf5b2d3-brittany-0.12.1.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9x573ymz2j3387gvhbdrkibhxj0cra1j-haskell-language-server-0.1.0.0.drv': 1 dependencies couldn't be built
[1 built (1 failed), 305 copied (2342.7 MiB), 181.3 MiB DL]
error: build of '/nix/store/9x573ymz2j3387gvhbdrkibhxj0cra1j-haskell-language-server-0.1.0.0.drv' failed

this package doesn't build for ghc 8.10.1

It would be needed to make overrides in all the different GHC configurations.

It is true I only tested 8.8.3 (current "main" GHC on nixpkgs)

Well that concrete issue seems likely to be solvable with one simple jailbreak and is an easy upstream issue.

@poscat0x04 If it's an upper bound issue, could you please report to upstream?

or we can disable brittany (https://github.com/haskell/haskell-language-server/blob/77c31c37aceb822ceb5b60f11f4933419353c675/stack-8.10.1.yaml#L26-L32)

this is the corresponding upstream issue: lspitzner/brittany#269

If it is bound to be fixed, we can just wait for upstream to fix.

Seems broken on GHC 8.6.5:

nix-repl> :b (import ../../nixpkgs {}).haskell.packages.ghc865.haskell-language-server
builder for '/nix/store/rfdc1s19l2j4ad0g79kw92dkglfa6a7f-rebase-1.6.1.drv' failed with exit code 1; last 10 log lines:
    die', called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:950:20 in Cabal-2.4.0.1:Distribution.Simple.Configure
    configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:460:12 in Cabal-2.4.0.1:Distribution.Simple.Configure
    configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:596:20 in Cabal-2.4.0.1:Distribution.Simple
    confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:67:5 in Cabal-2.4.0.1:Distribution.Simple.UserHooks
    configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:178:19 in Cabal-2.4.0.1:Distribution.Simple
    defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:115:27 in Cabal-2.4.0.1:Distribution.Simple
    defaultMain, called at Setup.hs:2:8 in main:Main
  Setup: Encountered missing dependencies:
  time ==1.9.*

@414owen at the time ghc 8.8 came out no one had ever heard of the haskell-language-server project. So I am not sure if it is very reasonable to expect this to work. That being said. Maybe you wanna try with "pkgs.haskell.lib.doJailbreak"?

Cool, I'll give it a shot.
Previously I was using haskell-language-server on 8.6.5 through nix with https://github.com/korayal/hls-nix/blob/master/default.nix
Pretty happy hls is landing in nixpkgs.

I definitly have to test on the different available GHCs, for now I only developped the expression for 8.6.5. My apologies for the lack of clarity about that.
If you could work on 8.6.5 @414owen I'd be really glad!

@GuillaumeDesforges sure thing. This line is all it took to get it to build on 8.6.5.