Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate nix.dev tutorials as a flake #486

Merged
merged 10 commits into from Sep 7, 2020
Merged

Integrate nix.dev tutorials as a flake #486

merged 10 commits into from Sep 7, 2020

Conversation

milibopp
Copy link
Contributor

@milibopp milibopp commented Jun 22, 2020 •
edited by garbas

was #484, now there should be a preview ;)

This replaces the current manually copy-pasted tutorials by the same content from https://github.com/domenkozar/nix.dev. This is a pretty selective extraction of individual guides from https://nix.dev.

Further extensions:

syntax highlighting via pygments as already generated by sphinx
integration of more guides

This change is Reviewable

@github-actions
Copy link
Contributor

🚀 Deployed on https://5ef0861e5de0e5de03686f3a--nixos-homepage.netlify.app

@garbas
Copy link
Member

garbas commented Jun 22, 2020

The last example

2020-06-22-133444_1880x730_scrot

shows a bit of unnecessary indent

@garbas
Copy link
Member

garbas commented Aug 20, 2020

/me merged latest master and resolved conflicts

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2020

🚀 Deployed on https://5f52e6d4080cf0009c62f36d--nixos-homepage.netlify.app

davidak
davidak suggested changes Sep 5, 2020
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The page title is not shown correctly in the browser:

Screenshot from 2020-09-05 03-27-24

There is a white space in front of ,, . and : in many cases!

Screenshot from 2020-09-05 03-31-56

Screenshot from 2020-09-05 03-34-05

maybe a problem with the import?

rest looks good. haven't read the actual content.

@garbas
pup -> xidel
aebcae3 
pup formatted the html which produced some white space.
@garbas
Copy link
Member

garbas commented Sep 7, 2020

@davidak nice catch ... should be fixed now.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2020

🚀 Deployed on https://5f567f3c72c9456991f324ae--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2020

🚀 Deployed on https://5f5689ed080cf03d4062f4ad--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2020

🚀 Deployed on https://5f568b959282d67c6db08576--nixos-homepage.netlify.app

@garbas garbas merged commit 461c762 into master Sep 7, 2020
@garbas garbas deleted the integrate-nix-dev branch September 7, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@milibopp @garbas @davidak