Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mockgen: init at 1.4.3 #91292

Merged
merged 2 commits into from Jul 26, 2020
Merged

mockgen: init at 1.4.3 #91292

merged 2 commits into from Jul 26, 2020

Conversation

bouk
Copy link
Contributor

@bouk bouk commented Jun 22, 2020

Motivation for this change

Add mockgen tool, and myself as a maintainer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit June 22, 2020 15:23
@zowoq
Copy link
Contributor

zowoq commented Jul 26, 2020

@bouk I rebased this to fix the merge conflict in maintainer-list.nix and moved your maintainer entry to be in alphabetical order.

@zowoq zowoq merged commit 352eeb0 into NixOS:master Jul 26, 2020
@bouk bouk deleted the mockgen branch July 29, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bouk @zowoq