Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: python3.pkgs.jax: init #91286

Closed
wants to merge 2 commits into from
Closed

WIP: python3.pkgs.jax: init #91286

wants to merge 2 commits into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jun 22, 2020

Motivation for this change

Because its so fun to package something that uses Bazel!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from mboes June 22, 2020 13:48
@teh
Copy link
Contributor

teh commented Dec 19, 2020

I think JAX uses bazel 3.1 now (https://github.com/google/jax/blob/master/.bazelversion) - does that make packaging easier?

@costrouc
Copy link
Member

Wish that I understood bazel builds better or I would help with this. What work would be needed to get this using the latest 0.1.49?

@stale
Copy link

stale bot commented Jul 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 26, 2021
@onny
Copy link
Contributor

onny commented Jul 30, 2022

python310Packages.jax is packaged now in NixOS. Hope its okay for me to close this :)

@onny onny closed this Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboes mboes Awaiting requested review from mboes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch will be requested when the pull request is marked ready for review Profpatsch is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@FRidh @teh @costrouc @onny @ryantm