Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old zeromq 3.x packages #91288

Merged
merged 5 commits into from Jul 26, 2020
Merged

Remove old zeromq 3.x packages #91288

merged 5 commits into from Jul 26, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Jun 22, 2020 •
edited

Motivation for this change

Clean up Nixpkgs, motived by #91032

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (would need help for apache-storm)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @peti for rzmq, @edwtjo @vizanto for apache-storm

@rnhmjoj
apache-storm: 1.2.1 -> 2.1.0
aef5ee6
@rnhmjoj
rzmq: use default zeromq
c7b3e54
@rnhmjoj
jzmq: remove
0006326 
This package does not support zeromq 4.x and is unmaintained.
@rnhmjoj
zeromq3: remove
8415766 
This zeromq version is really old and is no longer needed
by any package in Nixpkgs.
@rnhmjoj
aliases: add zeromq3 packages
7d20995
@rnhmjoj rnhmjoj requested a review from peti as a code owner June 22, 2020 13:50
@rnhmjoj rnhmjoj linked an issue Jun 22, 2020 that may be closed by this pull request
Vulnerability roundup 85: zeromq-3.2.5: 1 advisory #91032
Closed
1 task
@cole-h
Copy link
Member

cole-h commented Jun 23, 2020

@ofborg eval

We had a few misbehaving machines earlier (causing out of space errors on various PRs). They have since been decommissioned, so this should no longer be a problem.

@ofborg ofborg bot requested a review from edwtjo June 23, 2020 01:13
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Jun 23, 2020

@cole-h: thank you, I figured there was something wrong.

@rnhmjoj rnhmjoj merged commit bb395a9 into NixOS:master Jul 26, 2020
@rnhmjoj rnhmjoj deleted the zeromq branch July 10, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 85: zeromq-3.2.5: 1 advisory
2 participants
@rnhmjoj @cole-h