Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building with Ninja, simplify MinGW build instructions #11

Merged

Conversation

9names
Copy link
Contributor

@9names 9names commented Jun 22, 2020

Ninja (and probably other CMake targets) do not support file globbing, so list out the dependencies manually.
This is the recommended way of declaring dependencies/sources in CMake, as it can miss them if they don't exist when you first run CMake.

Updated install procedure for MinGW on the assumption the following pull request lands
azonenberg/scopehal-cmake#18
The environment variable MSYSTEM_PREFIX is set to system root (/mingw64 for x86_64 and /mingw32 for i686), so it should work for all MSYS2 builds.

I also tested a Ninja build on Windows under MSYS2 MinGW, can attest that it all builds as expected.

9names added 2 commits June 23, 2020 00:25
…rators that don't support globbing (eg Ninja) can successfully build docs
… prefix, and using make install. Note that this requires the ffts cmake improvements before scopehal can be built like this
@azonenberg azonenberg merged commit 481e84d into ngscopeclient:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants