Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg-full: add librsvg support #90170

Merged
merged 1 commit into from Jun 13, 2020
Merged

Conversation

expipiplus1
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

5 packages failed to build:
meguca python27Packages.pytmx python37Packages.pytmx python37Packages.rl-coach python38Packages.pytmx

24 packages built:
ffmpeg-full handbrake hydron kdenlive liquidsoap manim olive-editor printrun python27Packages.gym python27Packages.pydub python27Packages.pyglet python37Packages.baselines python37Packages.gym python37Packages.moderngl-window python37Packages.pydub python37Packages.pyglet python37Packages.roboschool python38Packages.gym python38Packages.moderngl-window python38Packages.pydub python38Packages.pyglet python38Packages.roboschool soundkonverter webcamoid

@jonringer jonringer merged commit 3e10731 into NixOS:master Jun 13, 2020
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Jun 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants