Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-assistant: 0.110.1 -> 0.111.0 #90126

Merged
merged 1 commit into from Jun 11, 2020
Merged

home-assistant: 0.110.1 -> 0.111.0 #90126

merged 1 commit into from Jun 11, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 11, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

Did someone ever try to get the NixOS test running again?

@Mic92
Copy link
Member Author

Mic92 commented Jun 11, 2020 •
edited

The test requires a human to perform the initial setup. We would need to either include this data or remove tests that require a login.

@dotlambda
Copy link
Member

dotlambda commented Jun 11, 2020 •
edited

But the documentation still mentions the legacy api password: https://www.home-assistant.io/docs/authentication/providers/#legacy-api-password

@Mic92
Copy link
Member Author

Mic92 commented Jun 11, 2020 •
edited

Yes. The API exists, however before the API can be used one has to go through an on-boarding process.

@ofborg ofborg bot requested review from dotlambda and globin June 11, 2020 10:24
@mweinelt
Copy link
Member

Hmm, we could do that with Selenium, but I'm not sure to what degree the Onboarding Process is a moving target.

@dotlambda
Copy link
Member

See #90149

mweinelt
mweinelt approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@Mic92
Copy link
Member Author

Mic92 commented Jun 11, 2020

Hmm, we could do that with Selenium, but I'm not sure to what degree the Onboarding Process is a moving target.

https://www.youtube.com/watch?v=WkODp99eQ4M

@Mic92 Mic92 merged commit d9ddd02 into NixOS:master Jun 11, 2020
@Mic92 Mic92 deleted the homeassistant branch June 11, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@colemickens colemickens Awaiting requested review from colemickens

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @dotlambda @mweinelt