ocamlPackages.js_of_ocaml_2: remove at 2.7 & 2.8.4 #90133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcdarwin
reviewed
Jun 12, 2020
pkgs/top-level/ocaml-packages.nix
Outdated
| base64 = base64_2; | ||
| lwt = lwt2; | ||
| }; | ||
| js_of_ocaml = callPackage ../development/tools/ocaml/js_of_ocaml/3.0.nix { }; |
There was a problem hiding this comment.
According to Nixpkgs convention, shouldn't the filename be changed from 3.0.nix to default.nix?
There was a problem hiding this comment.
Right. May this wait the next PR, say when updating js_of_ocaml to 3.6.0?
There was a problem hiding this comment.
You’re right. This change belongs to this PR. Thanks.
|
@GrahamcOfBorg build ocamlPackages.js_of_ocaml |
bcdarwin
approved these changes
Jun 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is no longer needed in
nixpkgs.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)