Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix licenses #90148

Merged
merged 11 commits into from Jun 11, 2020
Merged

Fix licenses #90148

merged 11 commits into from Jun 11, 2020

Conversation

markuskowa
Copy link
Member

Motivation for this change

Continuation on the way to resolve #43716

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

markuskowa referenced this pull request Jun 11, 2020
@doronbehar @Profpatsch
mpv-with-scripts: revive in aliases along with a warning
7be315a 
To prevent a breaking change while providing fully backwards compatible
interface to mpv-with-scripts, this replaces the harsh error using
`mpv-with-scripts` had.
@doronbehar
Copy link
Contributor

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from edolstra June 11, 2020 18:03
@markuskowa
Copy link
Member Author

@doronbehar OK, magic. works again.thanks!

@markuskowa markuskowa merged commit 3f2e6b9 into NixOS:master Jun 11, 2020
@markuskowa markuskowa deleted the fix-lics branch June 11, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais alyssais is a code owner

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing licenses
2 participants
@markuskowa @doronbehar