Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is possible to get a "Cost: £0" float from autoreplace. #8216

Closed
James103 opened this issue Jun 11, 2020 · 3 comments
Closed

It is possible to get a "Cost: £0" float from autoreplace. #8216

James103 opened this issue Jun 11, 2020 · 3 comments

Comments

@James103
Copy link
Contributor

Version of OpenTTD

1.10.2

Expected result

When a vehicle is replaced by another vehicle, and the value of the old vehicle is equal to the total purchase/refit price of the new vehicle, no "Cost: £0" float appears.

Actual result

When a vehicle is replaced by another vehicle, and the value of the old vehicle is equal to the total purchase/refit price of the new vehicle, a "Cost: £0" float appears.
image

Steps to reproduce

  1. Install a NewGRF that provides multiple vehicles at the same price (such as £0 as provided by Eyecandy road vehicles GRF).
  2. Build a road vehicle depot.
  3. Build a vehicle whose price is £0 (such as "Police car").
  4. In "Replace vehicles", select the vehicle, and select it to be replaced with another vehicle with a price of £0 (such as "Ambulance"). Hit the start replace button. Do not hit the replace button in the depot.
  5. Start the vehicle.
  6. Reverse the vehicle.
  7. Let it go back into the depot and get replaced.
  8. You should see a "Cost: £0" float when the vehicle is replaced.
@andythenorth
Copy link
Contributor

Thanks!

Is there a specific rationale for why this should be shown?

@James103
Copy link
Contributor Author

I think this is not intended. In all other unique places so far, no "Cost: £0", "Income: £0", or "Transfer: £0" float is produced. Additionally, if the cost of autoreplace is £0, the money check is skipped, but the "Cost: £0" float still displays.

@andythenorth
Copy link
Contributor

Sounds like a valid consistency issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants