Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode, vscodium: 1.45.1 -> 1.46.0 #90125

Merged
merged 2 commits into from Jun 13, 2020
Merged

vscode, vscodium: 1.45.1 -> 1.46.0 #90125

merged 2 commits into from Jun 13, 2020

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Jun 11, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kuznero kuznero self-assigned this Jun 11, 2020
@kuznero kuznero requested review from eadwu and Mic92 June 11, 2020 06:56
@kuznero
Copy link
Member Author

kuznero commented Jun 11, 2020

Does it make sense to introduce a small script to automatically update versions? If so, what tech is considered OK for this task (such that perhaps later on it is possible to automate on a bigger scale in NixPkgs)? ping @Mic92 .

@ofborg ofborg bot requested a review from Synthetica9 June 11, 2020 10:19
@Synthetica9
Copy link
Member

Does it make sense to introduce a small script to automatically update versions? If so, what tech is considered OK for this task (such that perhaps later on it is possible to automate on a bigger scale in NixPkgs)? ping @Mic92 .

I don't think there is standardised tech for this; perhaps something to integrate it with nixpkgs-auto-upgrade would be nice. An "update-script" meta field?

@kuznero kuznero changed the title vscode: 1.45.1 -> 1.46.0 vscode, vscodium: 1.45.1 -> 1.46.0 Jun 12, 2020
@kuznero
Copy link
Member Author

kuznero commented Jun 12, 2020

Everything should be ready, please merge.

@kuznero
Copy link
Member Author

kuznero commented Jun 12, 2020

Now, also includes a bash script to fetch latest versions for both VSCode and VSCodium. Please review and merge.

zowoq
zowoq reviewed Jun 13, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest moving the update script to a separate PR so that it doesn't block the version bumps.

pkgs/applications/editors/vscode/update.sh Outdated Show resolved Hide resolved
@kuznero kuznero mentioned this pull request Jun 13, 2020
Merged
10 tasks
@zowoq
Copy link
Contributor

zowoq commented Jun 13, 2020

Probably need to rebase this to drop the update script commits entirely rather than reverting.

@kuznero
Copy link
Member Author

kuznero commented Jun 13, 2020

Probably need to rebase this to drop the update script commits entirely rather than reverting.

Done

@zowoq
Copy link
Contributor

zowoq commented Jun 13, 2020

@ofborg eval

zowoq
zowoq approved these changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checksums match.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build vscode
@GrahamcOfBorg build vscodium

jonringer
jonringer approved these changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM

[10 built, 24 copied (75.1 MiB), 11.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/90125
3 packages built:
vscode vscode-with-extensions vscodium

@jonringer jonringer merged commit e25e560 into NixOS:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@zowoq zowoq zowoq approved these changes

@eadwu eadwu Awaiting requested review from eadwu

@Mic92 Mic92 Awaiting requested review from Mic92

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@kuznero kuznero

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kuznero @Synthetica9 @zowoq @jonringer