Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yq-go: 3.3.0 -> 3.3.1 #90166

Merged
merged 1 commit into from Jun 12, 2020
Merged

yq-go: 3.3.0 -> 3.3.1 #90166

merged 1 commit into from Jun 12, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jun 11, 2020

https://github.com/mikefarah/yq/releases/tag/3.3.1

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq marked this pull request as draft June 11, 2020 23:30
@ofborg ofborg bot requested review from nlewo and kalbasit June 11, 2020 23:35
@zowoq zowoq marked this pull request as ready for review June 11, 2020 23:38
@marsam
Copy link
Contributor

marsam commented Jun 12, 2020

looks like it added support for completions; Would you mind adding the following?

  postInstall = ''
    for shell in bash fish zsh; do
      $out/bin/yq shell-completion --variation $shell > yq.$shell
      installShellCompletion yq.$shell
    done
  '';

@zowoq
Copy link
Contributor Author

zowoq commented Jun 12, 2020 •
edited

looks like it added support for completions

They don't seem to work, I had already added them and then force pushed to drop them.

@marsam
Copy link
Contributor

marsam commented Jun 12, 2020

oh, did you try with the --variation flag?

@zowoq
Copy link
Contributor Author

zowoq commented Jun 12, 2020

oh, did you try with the --variation flag?

Apparently not, I must have dropped it instead of squashing so I actually tested the same command twice. 🤦

@marsam marsam merged commit d4406ed into NixOS:master Jun 12, 2020
@marsam
Copy link
Contributor

marsam commented Jun 12, 2020

Thank you

@zowoq zowoq deleted the yq-go branch June 12, 2020 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo Awaiting requested review from nlewo

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @marsam