Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mat2: init at 0.11.0 #90160

Closed
wants to merge 4 commits into from
Closed

mat2: init at 0.11.0 #90160

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2020

Motivation for this change

Adds mat2, a program designed to remove metadata information from a variety of file types. This can be useful for not accidentally revealing personal information when sending files.

Upstream is at: https://0xacab.org/jvoisin/mat2/

doCheck = false was set, as there was an issue with internal library detection during the check phase. If there is a known solution to this, please let me know.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/tools/graphics/mat2/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/mat2/default.nix Outdated Show resolved Hide resolved
sha256 = "beb99965eb41ebe022b6abed941aa0d23882e26b4b4b48f94295911a637f90ff";
};

# avoids AttributeError: module 'libmat2.archive' has no attribute 'ZipParser'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an upstream issue for this?

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
sha256 = "beb99965eb41ebe022b6abed941aa0d23882e26b4b4b48f94295911a637f90ff";
};

# avoids AttributeError: module 'libmat2.archive' has no attribute 'ZipParser'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please report upstream and add comment linking to report

meta = with lib; {
description = "metadata removal tool supporting a wide range of commonly used file formats";
homepage = "https://0xacab.org/jvoisin/mat2";
license = licenses.gpl3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gpl license variants without the Plus or Only suffix are deprecated, because they do not specify the license well enough. Use Plus if the project has "or later" sections in the actual source code files (not the license). Otherwise, use the Only suffix.

See https://discourse.nixos.org/t/lib-licenses-gpl3-co-are-now-deprecated/8206 for more details.

@ryantm
Copy link
Member

ryantm commented Oct 31, 2020

Result of nixpkgs-review pr 90160 1

1 package built:
- mat2

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 90160 run on x86_64-darwin 1

1 package built:
  • mat2

@SuperSandro2000
Copy link
Member

Closing because the author is a ghost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants