Use flake check for the documentation linting test #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
reviewed
Jun 11, 2020
adisbladis
requested changes
Jun 11, 2020
nlewo
force-pushed
the
flake-check
branch
3 times, most recently
from
7ad0044
to
4d85ec6
Compare
The main objective is to be able to locally run what the CI is running. Now, to run the doc linter, a user just have to run `nix flake check`. The `lint-docs` script is now available in the shell environment.
|
@adisbladis I think I've addressed all requests. Could you take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to easily run the documentation CI tests locally.
flake checkattribute.lint-docsis now part of the shell environment.The idea would be to move more CI scripts to
nix flake check: it is easier to discover them and to reproduce them.