New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p7zip: switch to maintained fork #90140
Conversation
@7c6f434c I left you as the maintainer of 7zip, if that's OK. I couldn't test the osx specific parts. |
Fine with me re: maintainer entry I think https://www.7-zip.org/links.html mentioning the new fork should be put into commit message — there are many places where 7-zip.org only links to old p7zip, and there are many forks; but indeed true-upstream seems to prefer this fork as the new one @ofborg build p7zip |
This the fork that true-upstream seems to prefer, see: https://www.7-zip.org/links.html
@7c6f434c Thanks, done. |
Maybe remove cross-commit references? Now they do not match (as Git seems to choose to include changelog into commit hash) |
Just to be clear, you mean keep the
Correct? |
Just to be clear, you mean keep the ``This reverts commit 5e52a39.`` but lose the
```
p7zip is now switched to a maintained fork, see commit:
944f51c71328ce0e6bca32ad5da17738fa8a64c6
```
Correct?
Well, only the second part (see commit)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dtrx and woeusb work for me
@7c6f434c OK, done. |
This PR needs to be linked to the according #88147 Report. |
@Anton-Latukha Thanks, I missed that. |
(looked up: ofborg complaint is about a warning instead of |
This reverts commit 64fdbcc. It seems that there is now[1] a maintained version of p7zip and since I didn't get used to unar so far, I take this opportunity to switch back to p7zip. [1]: NixOS/nixpkgs#90140 Signed-off-by: aszlig <aszlig@nix.build>
This the fork that true-upstream seems to prefer, see:
https://www.7-zip.org/links.html
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)