Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p7zip: switch to maintained fork #90140

Merged
merged 5 commits into from Jun 11, 2020
Merged

p7zip: switch to maintained fork #90140

merged 5 commits into from Jun 11, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jun 11, 2020

This the fork that true-upstream seems to prefer, see:
https://www.7-zip.org/links.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@magnetophon
Copy link
Member Author

magnetophon commented Jun 11, 2020

@7c6f434c I left you as the maintainer of 7zip, if that's OK.

I couldn't test the osx specific parts.

@7c6f434c
Copy link
Member

Fine with me re: maintainer entry

I think https://www.7-zip.org/links.html mentioning the new fork should be put into commit message — there are many places where 7-zip.org only links to old p7zip, and there are many forks; but indeed true-upstream seems to prefer this fork as the new one

@ofborg build p7zip

This the fork that true-upstream seems to prefer, see:
https://www.7-zip.org/links.html
@magnetophon
Copy link
Member Author

@7c6f434c Thanks, done.

@7c6f434c
Copy link
Member

Maybe remove cross-commit references? Now they do not match (as Git seems to choose to include changelog into commit hash)

@magnetophon
Copy link
Member Author

@7c6f434c

Maybe remove cross-commit references? Now they do not match (as Git seems to choose to include changelog into commit hash)

Just to be clear, you mean keep the This reverts commit 5e52a39. but lose the

p7zip is now switched to a maintained fork, see commit:
944f51c71328ce0e6bca32ad5da17738fa8a64c6

Correct?

@7c6f434c
Copy link
Member

7c6f434c commented Jun 11, 2020 via email

This reverts commit 9b3ca0c.
p7zip is now switched to a maintained fork
This reverts commit 9a2ec56.
p7zip is now switched to a maintained fork
This reverts commit 06fa14f.
p7zip is now switched to a maintained fork
This reverts commit 5e52a39.
p7zip is now switched to a maintained fork
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dtrx and woeusb work for me

@magnetophon
Copy link
Member Author

@7c6f434c OK, done.

@Anton-Latukha Anton-Latukha mentioned this pull request Jun 11, 2020
10 tasks
@Anton-Latukha
Copy link
Contributor

Anton-Latukha commented Jun 11, 2020

This PR needs to be linked to the according #88147 Report.

@magnetophon
Copy link
Member Author

@Anton-Latukha Thanks, I missed that.

@7c6f434c
Copy link
Member

(looked up: ofborg complaint is about a warning instead of throw in an unrelated package on master)

@7c6f434c 7c6f434c merged commit 61e57e8 into NixOS:master Jun 11, 2020
@magnetophon magnetophon deleted the p7zip branch June 11, 2020 17:04
aszlig added a commit to openlab-aux/vuizvui that referenced this pull request Jun 15, 2020
This reverts commit 64fdbcc.

It seems that there is now[1] a maintained version of p7zip and since I
didn't get used to unar so far, I take this opportunity to switch back
to p7zip.

[1]: NixOS/nixpkgs#90140

Signed-off-by: aszlig <aszlig@nix.build>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants