Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.mathcomp: 1.11.0 #90158

Merged
merged 1 commit into from Jun 12, 2020
Merged

coqPackages.mathcomp: 1.11.0 #90158

merged 1 commit into from Jun 12, 2020

Conversation

CohenCyril
Copy link
Contributor

Motivation for this change

Making coq package mathcomp 1.11.0 and extra developments on top of it
easily available via override.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CohenCyril
Copy link
Contributor Author

@GrahamcOfBorg build coqPackages_8_11.mathcomp coqPackages_8_11.mathcomp-analysis coqPackages_8_11.mathcomp-multinomials coqPackages_8_11.mathcomp-real-closed.

@vbgl Extensive tests have been performed here: https://github.com/math-comp/math-comp-nix/actions/runs/132533090 for every compatible pairs (coq-version, mathcomp-version)

@vbgl
Copy link
Contributor

vbgl commented Jun 12, 2020 •
edited

@GrahamcOfBorg build coqPackages.mathcomp-analysis

@vbgl
Copy link
Contributor

vbgl commented Jun 12, 2020

Why isn’t 1.11.0 the default version for mathcomp?

@CohenCyril
Copy link
Contributor Author

Why isn’t 1.11.0 the default version for mathcomp?

There are some major backward incompatibilities in there + we did not release odd-order and four-color for 1.11.0 yet. I thought I will not give it priority until at least those two packages are out.

@vbgl
Copy link
Contributor

vbgl commented Jun 12, 2020

Thanks for the clarification.

@vbgl vbgl merged commit b7f55b3 into NixOS:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl left review comments

Assignees
No one assigned
Labels
6.topic: coq 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CohenCyril @vbgl