Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

zabbix: 4.4.8 -> 5.0.2 #87712

Merged
merged 3 commits into from Aug 21, 2020
Merged

zabbix: 4.4.8 -> 5.0.2 #87712

merged 3 commits into from Aug 21, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented May 13, 2020

Motivation for this change

New LTS release of zabbix 馃帀

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM, but did no testing

@aanderse
Copy link
Member Author

Needs db changes yet. Still working on that.

@aanderse
Copy link
Member Author

ping @PsyanticY @mmahut this is finally ready. I have tested that both server and proxy correctly launch on new install and clicked around a bit on the web interface. Ready for merge, but would like a second set of eyes please.

@jonringer
Copy link
Contributor

https://github.com/NixOS/nixpkgs/pull/87712
1 package blacklisted:
tests.nixos-functions.nixos-test

7 packages built:
zabbix.agent zabbix.proxy-mysql zabbix.proxy-pgsql zabbix.proxy-sqlite zabbix.server zabbix.server-mysql zabbix.web

might be nice to get some nixosTests, be easier to assert they are working as intended

@aanderse
Copy link
Member Author

Agreed. Not sure if @mmahut was still working on that or not... at one point they were.

@aanderse aanderse changed the title zabbix: init at 5.0 zabbix: 4.4.8 -> 5.0.2 Aug 21, 2020
@aanderse aanderse merged commit 91db1c8 into NixOS:master Aug 21, 2020
@aanderse aanderse deleted the zabbix branch August 21, 2020 21:12
@aanderse aanderse mentioned this pull request Jun 15, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants