Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 14a3a62bfca6
Choose a base ref
...
head repository: NixOS/nix
compare: fbade0b7cc12
Choose a head ref
  • 4 commits
  • 3 files changed
  • 2 contributors

Commits on May 9, 2020

  1. InstallableExpr unused

    @mkenigs
    mkenigs committed May 9, 2020
    Copy the full SHA
    bf81dd4 View commit details
    Browse the repository at this point in the history

  2. Refactor installables 

    InstallableValue has children InstallableFlake and InstallableAttrPath, but InstallableFlake was overriding toDerivations, and usage was changed so that InstallableFlake didn't need cmd. So these changes were made:
InstallableValue::toDerivations() -> InstalllableAttrPath::toDerivations()
InstallableValue::cmd -> InstallableAttrPath::cmd

InstallableValue uses state instead of cmd

toBuildables() and toDerivations() were made abstract
    @mkenigs
    mkenigs committed May 9, 2020
    Copy the full SHA
    9f4cfbb View commit details
    Browse the repository at this point in the history

  3. Reorder to build 

    This reverts commit 883948d.
    @mkenigs
    mkenigs committed May 9, 2020
    Copy the full SHA
    73ee1af View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Merge pull request #3583 from mkenigs/InstallablesRefactor 

    Installables refactor
    @edolstra
    edolstra committed May 12, 2020
    Copy the full SHA
    fbade0b View commit details
    Browse the repository at this point in the history