New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
katago: 1.3.5 -> 1.4.2 #87676
katago: 1.3.5 -> 1.4.2 #87676
Conversation
Request for help. Current version of katagoWithCuda no longer builds. Neither does this version. The error received is during CMake's configure stage:
I encountered this error last time around, and I remember it being a compiler version issue, which is why I was on gcc8Stdenv for the CUDA build. This leads me to believe that there's perhaps an ABI mismatch between the new version of GCC (8.4.0) and the version that was available when this program was initially packaged (8.3.0). Because ofBorg and hydra won't build Cuda stuff, this won't fail any of the automatic tests. Soliciting ideas. |
fb7745a
to
676e1f4
Compare
I've pinned the issue down to a difference between cmake versions. CMake 3.16.3 works, whereas 3.17.0 does not. |
676e1f4
to
8d44783
Compare
Now everything works after a workaround patch to CMakeLists.txt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried downgrading cmake instead of patching? You could try cmake_2_8
which already has a top-level attribute. I don't know if it's too old, though.
In any case, I would wait for upstream to comment on the bug before accepting the patch.
Unfortunately, minimum CMake version required is 3.10.2 |
e5ae9cc
to
59f214f
Compare
Changed the patch to CMake-dev recommended solution, changed patch = changed sha = new push. |
@GrahamcOfBorg build katago |
59f214f
to
b1d8188
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the CMake devs comment, this is the correct solution.
Motivation for this change
Version bump
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)